fix(codemod): prevent duplicate path when transforming lint scripts#92944
Open
Jah-yee wants to merge 1 commit intovercel:canaryfrom
Open
fix(codemod): prevent duplicate path when transforming lint scripts#92944Jah-yee wants to merge 1 commit intovercel:canaryfrom
Jah-yee wants to merge 1 commit intovercel:canaryfrom
Conversation
…-pages rule The no-html-link-for-pages ESLint rule was hardcoded to only recognize .ts/.tsx/.js/.jsx page files. This commit makes it respect the pageExtensions config from settings.next, allowing it to work with custom file extensions like .mdx configured in next.config.js. Fixes vercel#53473
Author
|
Good day Thank you for your attention. If there are any issues or suggestions, please leave a comment and I will address them promptly. Warmly, |
Contributor
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
Summary
Fixed the
next-lint-to-eslint-clicodemod to avoid appending a duplicate.path when the original script already ends with..Root Cause
In
packages/next-codemod/transforms/next-lint-to-eslint-cli.ts, the script transformation logic processesnext lint --fix .and extracts.as a positional path argument. Then when building the result string, it adds all paths (including the.) followed by a separate default.when no paths are present. This results ineslint --fix . ..Fix
Added a check to detect whether the paths array already contains
.before appending the default. This ensures:next lint→eslint .(default.added)next lint --fix .→eslint --fix .(no duplicate.added)Testing
Verified locally with simulated test cases showing the fix works correctly for all edge cases.